DRMTalks
/
devine
mirror of https://github.com/devine-dl/devine.git
1
0
Fork 1
Code Issues Packages Projects Releases Wiki Activity

Don't print traceback of subprocess errors on download failures 

Since we now have pretty logs for them, the exception (which would be a CalledProcessError) would be generally pointless. However, the return code may be useful so that is kept.
This commit is contained in:
rlaphoenix 2023-03-03 02:38:45 +00:00
parent 9d6adec707
commit 714e9af99a
1 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
devine/commands/dl.py
View File

@ -6,6 +6,7 @@ import math
import random
import re
import shutil
import subprocess
import sys
import time
from concurrent import futures
@ -483,14 +484,19 @@ class dl:
(0, 5, 1, 5)
))
return
except Exception: # noqa
console.print_exception()
except Exception as e: # noqa
error_messages = [
":x: Download Failed...",
" One of the download workers had an error!",
" See the error trace above for more information."
]
if isinstance(e, subprocess.CalledProcessError):
# ignore process exceptions as proper error logs are already shown
error_messages.append(f" Process exit code: {e.returncode}")
else:
console.print_exception()
console.print(Padding(
Group(
":x: Download Failed...",
" One of the download workers had an error!",
" See the error trace above for more information."
),
Group(*error_messages),
(1, 5)
))
return