Mirror-Tools
/
shaka-packager
mirror of https://github.com/shaka-project/shaka-packager.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(http): Fix "Failed sending data to the peer" errors (#1443) 

Upgrading curl fixes errors like "Failed sending data to the peer" flooding the log.  This is described upstream in https://github.com/curl/curl/issues/10591 and fixed in curl 8.2.0.  Here we upgrade to curl 8.9.1 (latest as of today).

This required updating the way we attach c-ares to libcurl and updating CURLOPT_PUT (deprecated) to CURLOPT_UPLOAD (compatible equivalent AFAICT).
This commit is contained in:
Joey Parrish 2024-10-24 13:53:39 -07:00 committed by GitHub
parent ed68e69584
commit 2c9d100d44
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packager/file/http_file.cc
View File

@ -311,7 +311,7 @@ void HttpFile::SetupRequest() {
curl_easy_setopt(curl, CURLOPT_POST, 1L); curl_easy_setopt(curl, CURLOPT_POST, 1L);
break; break;
case HttpMethod::kPut: case HttpMethod::kPut:
curl_easy_setopt(curl, CURLOPT_PUT, 1L); curl_easy_setopt(curl, CURLOPT_UPLOAD, 1L);
break; break;
} }

2
packager/third_party/curl/CMakeLists.txt vendored
View File

@ -45,5 +45,5 @@ add_subdirectory(source)
# Our enabling of c-ares doesn't automatically set a dependency between libcurl # Our enabling of c-ares doesn't automatically set a dependency between libcurl
# and c-ares. Fix that now. # and c-ares. Fix that now.
if(USE_ARES) if(USE_ARES)
target_link_libraries(libcurl c-ares) target_link_libraries(libcurl_static PUBLIC c-ares)
endif() endif()

2
packager/third_party/curl/source vendored

@ -1 +1 @@
Subproject commit 462196e6b4a47f924293a0e26b8e9c23d37ac26f Subproject commit 83bedbd730d62b83744cc26fa0433d3f6e2e4cd6