From 388d49cf98f684b618252268042485b7096178f0 Mon Sep 17 00:00:00 2001 From: Aaron Vaage Date: Mon, 21 May 2018 10:02:47 -0700 Subject: [PATCH] Rename webvtt_output_handler files Renamed all the files called "webvtt_output_handler*" to "webvtt_text_output_handler*" to better reflect the class name in them. Change-Id: I977bab362076974a124f263bcefff716ed8b6a0f --- dump-1.txt | 45 +++++++++++++++++++ dump-2.txt | 45 +++++++++++++++++++ packager/media/formats/webvtt/webvtt.gyp | 6 +-- ...ndler.cc => webvtt_text_output_handler.cc} | 2 +- ...handler.h => webvtt_text_output_handler.h} | 0 ...=> webvtt_text_output_handler_unittest.cc} | 2 +- packager/packager.cc | 2 +- 7 files changed, 96 insertions(+), 6 deletions(-) create mode 100644 dump-1.txt create mode 100644 dump-2.txt rename packager/media/formats/webvtt/{webvtt_output_handler.cc => webvtt_text_output_handler.cc} (98%) rename packager/media/formats/webvtt/{webvtt_output_handler.h => webvtt_text_output_handler.h} (100%) rename packager/media/formats/webvtt/{webvtt_output_handler_unittest.cc => webvtt_text_output_handler_unittest.cc} (99%) diff --git a/dump-1.txt b/dump-1.txt new file mode 100644 index 0000000000..01b604a459 --- /dev/null +++ b/dump-1.txt @@ -0,0 +1,45 @@ +00000000: 0000 0020 6674 7970 6973 6f6d 0000 0000 ... ftypisom.... +00000010: 6973 6f38 6d70 3431 6461 7368 636d 6663 iso8mp41dashcmfc +00000020: 0000 02ae 6d6f 6f76 0000 006c 6d76 6864 ....moov...lmvhd +00000030: 0000 0000 7c25 b080 7c25 b080 0000 03e8 ....|%..|%...... +00000040: 0000 0000 0001 0000 0100 0000 0000 0000 ................ +00000050: 0000 0000 0001 0000 0000 0000 0000 0000 ................ +00000060: 0000 0000 0001 0000 0000 0000 0000 0000 ................ +00000070: 0000 0000 4000 0000 0000 0000 0000 0000 ....@........... +00000080: 0000 0000 0000 0000 0000 0000 0000 0000 ................ +00000090: 0000 0002 0000 008a 6d65 7461 0000 0000 ........meta.... +000000a0: 0000 0020 6864 6c72 0000 0000 0000 0000 ... hdlr........ +000000b0: 4944 3332 0000 0000 0000 0000 0000 0000 ID32............ +000000c0: 0000 005e 4944 3332 0000 0000 15c7 4944 ...^ID32......ID +000000d0: 3304 0000 0000 0046 5052 4956 0000 003c 3......FPRIV...< +000000e0: 0000 6874 7470 733a 2f2f 6769 7468 7562 ..https://github +000000f0: 2e63 6f6d 2f67 6f6f 676c 652f 7368 616b .com/google/shak +00000100: 612d 7061 636b 6167 6572 003c 7461 673e a-packager. +00000110: 2d3c 6861 7368 3e2d 3c74 6573 743e 0000 --.. +00000120: 0178 7472 616b 0000 005c 746b 6864 0000 .xtrak...\tkhd.. +00000130: 0007 7c25 b080 7c25 b080 0000 0001 0000 ..|%..|%........ +00000140: 0000 0000 0000 0000 0000 0000 0000 0000 ................ +00000150: 0000 0100 0000 0001 0000 0000 0000 0000 ................ +00000160: 0000 0000 0000 0001 0000 0000 0000 0000 ................ +00000170: 0000 0000 0000 4000 0000 0000 0000 0000 ......@......... +00000180: 0000 0000 0114 6d64 6961 0000 0020 6d64 ......mdia... md +00000190: 6864 0000 0000 7c25 b080 7c25 b080 0000 hd....|%..|%.... +000001a0: 03e8 0000 0000 55c4 0000 0000 002c 6864 ......U......,hd +000001b0: 6c72 0000 0000 0000 0000 7465 7874 0000 lr........text.. +000001c0: 0000 0000 0000 0000 0000 5465 7874 4861 ..........TextHa +000001d0: 6e64 6c65 7200 0000 00c0 6d69 6e66 0000 ndler.....minf.. +000001e0: 0024 6469 6e66 0000 001c 6472 6566 0000 .$dinf....dref.. +000001f0: 0000 0000 0001 0000 000c 7572 6c20 0000 ..........url .. +00000200: 0001 0000 0088 7374 626c 0000 003c 7374 ......stbl... +00000110: 2d3c 6861 7368 3e2d 3c74 6573 743e 0000 --.. +00000120: 0178 7472 616b 0000 005c 746b 6864 0000 .xtrak...\tkhd.. +00000130: 0007 7c25 b080 7c25 b080 0000 0001 0000 ..|%..|%........ +00000140: 0000 0000 0000 0000 0000 0000 0000 0000 ................ +00000150: 0000 0100 0000 0001 0000 0000 0000 0000 ................ +00000160: 0000 0000 0000 0001 0000 0000 0000 0000 ................ +00000170: 0000 0000 0000 4000 0000 0000 0000 0000 ......@......... +00000180: 0000 0000 0114 6d64 6961 0000 0020 6d64 ......mdia... md +00000190: 6864 0000 0000 7c25 b080 7c25 b080 0000 hd....|%..|%.... +000001a0: 03e8 0000 0000 55c4 0000 0000 002c 6864 ......U......,hd +000001b0: 6c72 0000 0000 0000 0000 7465 7874 0000 lr........text.. +000001c0: 0000 0000 0000 0000 0000 5465 7874 4861 ..........TextHa +000001d0: 6e64 6c65 7200 0000 00c0 6d69 6e66 0000 ndler.....minf.. +000001e0: 0024 6469 6e66 0000 001c 6472 6566 0000 .$dinf....dref.. +000001f0: 0000 0000 0001 0000 000c 7572 6c20 0000 ..........url .. +00000200: 0001 0000 0088 7374 626c 0000 003c 7374 ......stbl... // needed for min and max diff --git a/packager/media/formats/webvtt/webvtt_output_handler.h b/packager/media/formats/webvtt/webvtt_text_output_handler.h similarity index 100% rename from packager/media/formats/webvtt/webvtt_output_handler.h rename to packager/media/formats/webvtt/webvtt_text_output_handler.h diff --git a/packager/media/formats/webvtt/webvtt_output_handler_unittest.cc b/packager/media/formats/webvtt/webvtt_text_output_handler_unittest.cc similarity index 99% rename from packager/media/formats/webvtt/webvtt_output_handler_unittest.cc rename to packager/media/formats/webvtt/webvtt_text_output_handler_unittest.cc index c84b1a7b8c..916f4d5776 100644 --- a/packager/media/formats/webvtt/webvtt_output_handler_unittest.cc +++ b/packager/media/formats/webvtt/webvtt_text_output_handler_unittest.cc @@ -12,7 +12,7 @@ #include "packager/media/base/text_stream_info.h" #include "packager/media/event/combined_muxer_listener.h" #include "packager/media/event/mock_muxer_listener.h" -#include "packager/media/formats/webvtt/webvtt_output_handler.h" +#include "packager/media/formats/webvtt/webvtt_text_output_handler.h" #include "packager/status_test_util.h" namespace shaka { diff --git a/packager/packager.cc b/packager/packager.cc index fbca281c24..1d3a95f8db 100644 --- a/packager/packager.cc +++ b/packager/packager.cc @@ -42,8 +42,8 @@ #include "packager/media/event/vod_media_info_dump_muxer_listener.h" #include "packager/media/formats/webvtt/text_padder.h" #include "packager/media/formats/webvtt/text_readers.h" -#include "packager/media/formats/webvtt/webvtt_output_handler.h" #include "packager/media/formats/webvtt/webvtt_parser.h" +#include "packager/media/formats/webvtt/webvtt_text_output_handler.h" #include "packager/media/formats/webvtt/webvtt_to_mp4_handler.h" #include "packager/media/replicator/replicator.h" #include "packager/media/trick_play/trick_play_handler.h"