Mirror-Tools
/
shaka-packager
mirror of https://github.com/shaka-project/shaka-packager.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Put AudioChannelConfig before ContentProtection 

AudioChannelConfig should appear before ContentProtection in
Representation.
Enabled tests which covers this case.

Bug: 13227181
Change-Id: I0f4e913304ad982761a9296aa95d30200f6314d2
This commit is contained in:
Rintaro Kuroiwa 2014-03-04 12:38:06 -08:00
parent 5708e90c82
commit 482c60ca1e
3 changed files with 19 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
mpd/base/mpd_builder.cc
View File

@ -315,6 +315,9 @@ bool Representation::Init() {
if (!has_video_info && !has_audio_info) { if (!has_video_info && !has_audio_info) {
// TODO(rkuroiwa): Allow text input. // TODO(rkuroiwa): Allow text input.
// This is an error. Segment information can be in AdaptationSet, Period, or
// MPD but the interface does not provide a way to set them.
// See 5.3.9.1 ISO 23009-1:2012 for segment info.
LOG(ERROR) << "Representation needs video or audio."; LOG(ERROR) << "Representation needs video or audio.";
return false; return false;
} }
@ -355,22 +358,19 @@ bool Representation::AddNewSegment(uint64 start_time, uint64 duration) {
// internal copy of this element. Then move most of the logic to // internal copy of this element. Then move most of the logic to
// RepresentationXmlNode so that all the work is done in it so that this class // RepresentationXmlNode so that all the work is done in it so that this class
// just becomes a thin layer. // just becomes a thin layer.
//
// Uses info in |media_info_| and |content_protection_elements_| to create a // Uses info in |media_info_| and |content_protection_elements_| to create a
// "Representation" node. // "Representation" node.
// MPD schema has strict ordering. The following must be done in order.
// AddVideoInfo() (possibly adds FramePacking elements), AddAudioInfo() (Adds
// AudioChannelConfig elements), AddContentProtectionElements*(), and
// AddVODOnlyInfo() (Adds segment info).
xml::ScopedXmlPtr<xmlNode>::type Representation::GetXml() { xml::ScopedXmlPtr<xmlNode>::type Representation::GetXml() {
base::AutoLock scoped_lock(lock_); base::AutoLock scoped_lock(lock_);
DCHECK(!(HasVODOnlyFields(media_info_) && HasLiveOnlyFields(media_info_))); DCHECK(!(HasVODOnlyFields(media_info_) && HasLiveOnlyFields(media_info_)));
DCHECK(media_info_.has_bandwidth()); DCHECK(media_info_.has_bandwidth());
RepresentationXmlNode representation; RepresentationXmlNode representation;
if (!representation.AddContentProtectionElements(
content_protection_elements_)) {
return xml::ScopedXmlPtr<xmlNode>::type();
}
if (!representation.AddContentProtectionElementsFromMediaInfo(media_info_))
return xml::ScopedXmlPtr<xmlNode>::type();
// Mandatory fields for Representation. // Mandatory fields for Representation.
representation.SetId(id_); representation.SetId(id_);
representation.SetIntegerAttribute("bandwidth", media_info_.bandwidth()); representation.SetIntegerAttribute("bandwidth", media_info_.bandwidth());
@ -392,11 +392,17 @@ xml::ScopedXmlPtr<xmlNode>::type Representation::GetXml() {
return xml::ScopedXmlPtr<xmlNode>::type(); return xml::ScopedXmlPtr<xmlNode>::type();
} }
if (!representation.AddContentProtectionElements(
content_protection_elements_)) {
return xml::ScopedXmlPtr<xmlNode>::type();
}
if (!representation.AddContentProtectionElementsFromMediaInfo(media_info_))
return xml::ScopedXmlPtr<xmlNode>::type();
// TODO(rkuroiwa): Add TextInfo. // TODO(rkuroiwa): Add TextInfo.
// TODO(rkuroiwa): Add ContentProtection info.
if (HasVODOnlyFields(media_info_) && if (HasVODOnlyFields(media_info_) &&
!representation.AddVODOnlyInfo(media_info_)) { !representation.AddVODOnlyInfo(media_info_)) {
LOG(ERROR) << "Failed to add VOD info."; LOG(ERROR) << "Failed to add VOD segment info.";
return xml::ScopedXmlPtr<xmlNode>::type(); return xml::ScopedXmlPtr<xmlNode>::type();
} }

5
mpd/base/mpd_builder_unittest.cc
View File

@ -15,7 +15,7 @@ namespace dash_packager {
class StaticMpdBuilderTest : public ::testing::Test { class StaticMpdBuilderTest : public ::testing::Test {
public: public:
StaticMpdBuilderTest() : mpd_(MpdBuilder::kStatic) {} StaticMpdBuilderTest() : mpd_(MpdBuilder::kStatic) {}
~StaticMpdBuilderTest() {} virtual ~StaticMpdBuilderTest() {}
void CheckMpd(const std::string& expected_output_file) { void CheckMpd(const std::string& expected_output_file) {
std::string mpd_doc; std::string mpd_doc;
@ -73,8 +73,7 @@ TEST_F(StaticMpdBuilderTest, VideoAndAudio) {
// MPD schema has strict ordering. AudioChannelConfiguration must appear before // MPD schema has strict ordering. AudioChannelConfiguration must appear before
// ContentProtection. // ContentProtection.
// TODO(rkuroiwa): Enable this when implemented. // TODO(rkuroiwa): Enable this when implemented.
TEST_F(StaticMpdBuilderTest, TEST_F(StaticMpdBuilderTest, AudioChannelConfigurationWithContentProtection) {
DISABLED_AudioChannelConfigurationWithContentProtection) {
MediaInfo encrypted_audio_media_info = MediaInfo encrypted_audio_media_info =
GetTestMediaInfo(kFileNameEncytpedAudioMediaInfo); GetTestMediaInfo(kFileNameEncytpedAudioMediaInfo);

2
mpd/util/mpd_writer_unittest.cc
View File

@ -81,7 +81,7 @@ TEST(MpdWriterTest, VideoAudioMediaInfo) {
} }
// TODO(rkuroiwa): Enable this when implemented. // TODO(rkuroiwa): Enable this when implemented.
TEST(MpdWriterTest, DISABLED_EncryptedAudioMediaInfo) { TEST(MpdWriterTest, EncryptedAudioMediaInfo) {
MpdWriter mpd_writer; MpdWriter mpd_writer;
base::FilePath encrypted_audio_media_info = base::FilePath encrypted_audio_media_info =
GetTestDataFilePath(kFileNameEncytpedAudioMediaInfo); GetTestDataFilePath(kFileNameEncytpedAudioMediaInfo);