Mirror-Tools
/
shaka-packager
mirror of https://github.com/shaka-project/shaka-packager.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ci: Use GITHUB_TOKEN instead of SHAKA_BOT_TOKEN (#977) 

There is not a good reason to use a long-lived token attached to
shaka-bot.  Instead, use a short-lived, automatic token generated by
GitHub Actions for the workflow run.
This commit is contained in:
Joey Parrish 2021-08-12 10:50:29 -07:00 committed by GitHub
parent cfbe5c08c2
commit 507a731a9a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
.github/workflows/README.md vendored
View File

@ -47,7 +47,3 @@
- `NPM_PACKAGE_NAME`: Not a true "secret", but stored here to avoid someone - `NPM_PACKAGE_NAME`: Not a true "secret", but stored here to avoid someone
pushing bogus packages to NPM during CI testing from a fork pushing bogus packages to NPM during CI testing from a fork
- In a fork, set to a private name which differs from the production one - In a fork, set to a private name which differs from the production one
- `SHAKA_BOT_TOKEN`: A GitHub personal access token for the `shaka-bot`
account, with `workflow` scope
- To generate, visit https://github.com/settings/tokens/new and select the
`workflow` scope

6
.github/workflows/github_release.yaml vendored
View File

@ -84,7 +84,7 @@ jobs:
id: draft_release id: draft_release
uses: actions/create-release@v1 uses: actions/create-release@v1
env: env:
GITHUB_TOKEN: ${{ secrets.SHAKA_BOT_TOKEN }} GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with: with:
tag_name: ${{ needs.setup.outputs.tag }} tag_name: ${{ needs.setup.outputs.tag }}
release_name: ${{ needs.setup.outputs.tag }} release_name: ${{ needs.setup.outputs.tag }}
@ -170,7 +170,7 @@ jobs:
if: matrix.build_type == 'Release' && matrix.lib_type == 'static' if: matrix.build_type == 'Release' && matrix.lib_type == 'static'
uses: dwenegar/upload-release-assets@v1 uses: dwenegar/upload-release-assets@v1
env: env:
GITHUB_TOKEN: ${{ secrets.SHAKA_BOT_TOKEN }} GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with: with:
release_id: ${{ needs.draft_release.outputs.release_id }} release_id: ${{ needs.draft_release.outputs.release_id }}
assets_path: artifacts assets_path: artifacts
@ -183,6 +183,6 @@ jobs:
- name: Publish release - name: Publish release
uses: eregon/publish-release@v1 uses: eregon/publish-release@v1
env: env:
GITHUB_TOKEN: ${{ secrets.SHAKA_BOT_TOKEN }} GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with: with:
release_id: ${{ needs.draft_release.outputs.release_id }} release_id: ${{ needs.draft_release.outputs.release_id }}

2
.github/workflows/update_docs.yaml vendored
View File

@ -45,6 +45,6 @@ jobs:
- name: Deploy to gh-pages branch - name: Deploy to gh-pages branch
uses: peaceiris/actions-gh-pages@v3 uses: peaceiris/actions-gh-pages@v3
with: with:
github_token: ${{ secrets.SHAKA_BOT_TOKEN }} github_token: ${{ secrets.GITHUB_TOKEN }}
publish_dir: gh-pages publish_dir: gh-pages
full_commit_message: Generate docs for ${{ steps.ref.outputs.ref }} full_commit_message: Generate docs for ${{ steps.ref.outputs.ref }}