From 98782c051ee3bb2f0acb4827cd9edbfcd4f863f4 Mon Sep 17 00:00:00 2001
From: Joey Parrish <joeyparrish@google.com>
Date: Mon, 14 Jun 2021 12:14:02 -0700
Subject: [PATCH] Skip clang updates on Windows

We do not use clang to build on Windows, so we should skip trying to
update clang.  This is critical to MSVS 2019 support, since the older
clang tools we depend on do not recognize that newer environment.
Since we don't need clang anyway, skipping the update avoids useless
errors about finding a matching clang version for the environment.

Issue #867 (MSVS 2019)
Issue #336 (progress toward replacing Travis & Appveyor with GitHub
  Actions, which uses MSVS 2019)
b/190743862 (internal; tracking replacement of Travis)

Change-Id: I5600ed809b11e68444034a06cc891403e6bfb5cc
---
 DEPS | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/DEPS b/DEPS
index 31e4ec3d9f..27b00e252c 100644
--- a/DEPS
+++ b/DEPS
@@ -111,6 +111,8 @@ hooks = [
   {
     # Pull clang if needed or requested via GYP_DEFINES (GYP_DEFINES="clang=1").
     "name": "clang",
+    # Skip clang updates on Windows, where we don't use clang.
+    "condition": "not checkout_win",
     "pattern": ".",
     "action": ["python", "src/packager/tools/clang/scripts/update.py", "--if-needed"],
   },