Mirror-Tools
/
shaka-packager
mirror of https://github.com/shaka-project/shaka-packager.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: Add Missing Dash Roles to RoleFromString function (#1418) (#1419) 

As per issue #1418, several Dash roles are missing from the
RoleFromString function, making them unusable in practice. This update
should enable them for use.

---------

Co-authored-by: John Laurin <john.laurin@svt.se>
This commit is contained in:
John Laurin 2024-08-29 03:59:57 +02:00 committed by GitHub
parent b5c2cb8b73
commit 9cb00e91ab
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
AUTHORS
View File

@ -39,4 +39,5 @@ Richard Eklycke <richard@eklycke.se>
Sanil Raut <sr1990003@gmail.com> Sanil Raut <sr1990003@gmail.com>
Sergio Ammirata <sergio@ammirata.net> Sergio Ammirata <sergio@ammirata.net>
The Chromium Authors <*@chromium.org> The Chromium Authors <*@chromium.org>
Sveriges Television AB <*@svt.se>

1
CONTRIBUTORS
View File

@ -57,4 +57,5 @@ Tim Lansen <tim.lansen@gmail.com>
Torbjörn Einarsson <torbjorn.einarsson@eyevinn.se> Torbjörn Einarsson <torbjorn.einarsson@eyevinn.se>
Vincent Nguyen <nvincen@amazon.com> Vincent Nguyen <nvincen@amazon.com>
Weiguo Shao <weiguo.shao@dolby.com> Weiguo Shao <weiguo.shao@dolby.com>
John Laurin <john.laurin@svt.se>

12
packager/mpd/base/period.cc
View File

@ -44,6 +44,18 @@ AdaptationSet::Role RoleFromString(const std::string& role_str) {
return AdaptationSet::Role::kRoleDub; return AdaptationSet::Role::kRoleDub;
if (role_str == "forced-subtitle") if (role_str == "forced-subtitle")
return AdaptationSet::Role::kRoleForcedSubtitle; return AdaptationSet::Role::kRoleForcedSubtitle;
if (role_str == "karaoke")
return AdaptationSet::Role::kRoleKaraoke;
if (role_str == "sign")
return AdaptationSet::Role::kRoleSign;
if (role_str == "metadata")
return AdaptationSet::Role::kRoleMetadata;
if (role_str == "enhanced-audio-intelligibility")
return AdaptationSet::Role::kRoleEnhancedAudioIntelligibility;
if (role_str == "emergency")
return AdaptationSet::Role::kRoleEmergency;
if (role_str == "easyreader")
return AdaptationSet::Role::kRoleEasyreader;
if (role_str == "description") if (role_str == "description")
return AdaptationSet::Role::kRoleDescription; return AdaptationSet::Role::kRoleDescription;
return AdaptationSet::Role::kRoleUnknown; return AdaptationSet::Role::kRoleUnknown;