Mirror-Tools
/
shaka-packager
mirror of https://github.com/shaka-project/shaka-packager.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

feat(HTTP): Retry failed HTTP requests with exponential backoff

This commit is contained in:
meryacine 2022-09-09 11:12:21 +02:00 committed by Omer Yacine
parent 76eb2c1575
commit b2ccb155cd
No known key found for this signature in database
GPG Key ID: C3BED6698142B393
1 changed files with 39 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

49
packager/file/http_file.cc
View File

@ -6,6 +6,8 @@
#include <packager/file/http_file.h>
#include <thread>
#include <absl/flags/declare.h>
#include <absl/flags/flag.h>
#include <absl/log/check.h>
@ -55,6 +57,10 @@ namespace {
constexpr const char* kBinaryContentType = "application/octet-stream";
constexpr const int kMinLogLevelForCurlDebugFunction = 2;
// The number of times to retry requesting the server before we give up.
constexpr const int kNumRequestErrorRetries = 5;
constexpr const int kFirstRetryDelayMilliseconds = 1000;
size_t CurlWriteCallback(char* buffer, size_t size, size_t nmemb, void* user) {
IoCache* cache = reinterpret_cast<IoCache*>(user);
size_t length = size * nmemb;
@ -135,13 +141,9 @@ int CurlDebugCallback(CURL* /* handle */,
class LibCurlInitializer {
public:
LibCurlInitializer() {
curl_global_init(CURL_GLOBAL_DEFAULT);
}
LibCurlInitializer() { curl_global_init(CURL_GLOBAL_DEFAULT); }
~LibCurlInitializer() {
curl_global_cleanup();
}
~LibCurlInitializer() { curl_global_cleanup(); }
LibCurlInitializer(const LibCurlInitializer&) = delete;
LibCurlInitializer& operator=(const LibCurlInitializer&) = delete;
@ -224,9 +226,6 @@ bool HttpFile::Open() {
}
// TODO: Try to connect initially so we can return connection error here.
// TODO: Implement retrying with exponential backoff, see
// "widevine_key_source.cc"
ThreadPool::instance.PostTask(std::bind(&HttpFile::ThreadMain, this));
return true;
@ -357,8 +356,38 @@ void HttpFile::SetupRequest() {
void HttpFile::ThreadMain() {
SetupRequest();
CURLcode res;
int64_t sleep_duration = kFirstRetryDelayMilliseconds;
// Try sending the request multiple times if it fails.
for (int i = 0; i < kNumRequestErrorRetries; ++i) {
res = curl_easy_perform(curl_.get());
if (res == CURLE_HTTP_RETURNED_ERROR) {
long res_code = 0;
curl_easy_getinfo(curl_.get(), CURLINFO_RESPONSE_CODE, &res_code);
if (res_code == 408 || res_code == 429 || res_code >= 500) {
// FIXME: Should we clear download_cache_ and upload_cache_ here??
// Retry.
} else {
// Exponential backoff won't help for this response code, Stop retrying.
break;
}
} else if (res == CURLE_OPERATION_TIMEDOUT) {
// Retry.
} else {
// Either the request was successful or exponential backoff won't help.
// Stop retrying.
break;
}
// Exponential backoff.
if (i != kNumRequestErrorRetries - 1) {
std::this_thread::sleep_for(std::chrono::milliseconds(sleep_duration));
sleep_duration *= 2;
}
}
CURLcode res = curl_easy_perform(curl_.get());
if (res != CURLE_OK) {
std::string error_message = curl_easy_strerror(res);
if (res == CURLE_HTTP_RETURNED_ERROR) {