Mirror-Tools
/
shaka-packager
mirror of https://github.com/shaka-project/shaka-packager.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add Missing ASSERT_OK Calls in Cue Alignment Tests 

The SetUpAndInitialize function returns a status. We were not
asserting that it return an OK status. This change adds the
missing ASSERT_OK calls.

Change-Id: I044f60c0450d46fc0f6495319b1ed7ef8ab6e794
This commit is contained in:
Aaron Vaage 2018-05-22 14:24:50 -07:00
parent b01de0bfb6
commit b69eb49f77
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
packager/media/chunking/cue_alignment_handler_unittest.cc
View File

@ -81,7 +81,7 @@ TEST_F(CueAlignmentHandlerTest, VideoInputWithNoCues) {
SyncPointQueue sync_points(params); SyncPointQueue sync_points(params);
std::shared_ptr<MediaHandler> handler = std::shared_ptr<MediaHandler> handler =
std::make_shared<CueAlignmentHandler>(&sync_points); std::make_shared<CueAlignmentHandler>(&sync_points);
SetUpAndInitializeGraph(handler, kOneInput, kOneOutput); ASSERT_OK(SetUpAndInitializeGraph(handler, kOneInput, kOneOutput));
{ {
testing::InSequence s; testing::InSequence s;
@ -125,7 +125,7 @@ TEST_F(CueAlignmentHandlerTest, AudioInputWithNoCues) {
SyncPointQueue sync_points(params); SyncPointQueue sync_points(params);
std::shared_ptr<MediaHandler> handler = std::shared_ptr<MediaHandler> handler =
std::make_shared<CueAlignmentHandler>(&sync_points); std::make_shared<CueAlignmentHandler>(&sync_points);
SetUpAndInitializeGraph(handler, kOneInput, kOneOutput); ASSERT_OK(SetUpAndInitializeGraph(handler, kOneInput, kOneOutput));
{ {
testing::InSequence s; testing::InSequence s;
@ -173,7 +173,7 @@ TEST_F(CueAlignmentHandlerTest, TextInputWithNoCues) {
SyncPointQueue sync_points(params); SyncPointQueue sync_points(params);
std::shared_ptr<MediaHandler> handler = std::shared_ptr<MediaHandler> handler =
std::make_shared<CueAlignmentHandler>(&sync_points); std::make_shared<CueAlignmentHandler>(&sync_points);
SetUpAndInitializeGraph(handler, kOneInput, kOneOutput); ASSERT_OK(SetUpAndInitializeGraph(handler, kOneInput, kOneOutput));
{ {
testing::InSequence s; testing::InSequence s;
@ -223,7 +223,7 @@ TEST_F(CueAlignmentHandlerTest, TextAudioVideoInputWithNoCues) {
SyncPointQueue sync_points(params); SyncPointQueue sync_points(params);
std::shared_ptr<MediaHandler> handler = std::shared_ptr<MediaHandler> handler =
std::make_shared<CueAlignmentHandler>(&sync_points); std::make_shared<CueAlignmentHandler>(&sync_points);
SetUpAndInitializeGraph(handler, kThreeInput, kThreeOutput); ASSERT_OK(SetUpAndInitializeGraph(handler, kThreeInput, kThreeOutput));
{ {
testing::InSequence s; testing::InSequence s;
@ -347,7 +347,7 @@ TEST_F(CueAlignmentHandlerTest, VideoInputWithCues) {
SyncPointQueue sync_points(params); SyncPointQueue sync_points(params);
std::shared_ptr<MediaHandler> handler = std::shared_ptr<MediaHandler> handler =
std::make_shared<CueAlignmentHandler>(&sync_points); std::make_shared<CueAlignmentHandler>(&sync_points);
SetUpAndInitializeGraph(handler, kOneInput, kOneOutput); ASSERT_OK(SetUpAndInitializeGraph(handler, kOneInput, kOneOutput));
{ {
testing::InSequence s; testing::InSequence s;
@ -401,7 +401,7 @@ TEST_F(CueAlignmentHandlerTest, AudioInputWithCues) {
SyncPointQueue sync_points(params); SyncPointQueue sync_points(params);
std::shared_ptr<MediaHandler> handler = std::shared_ptr<MediaHandler> handler =
std::make_shared<CueAlignmentHandler>(&sync_points); std::make_shared<CueAlignmentHandler>(&sync_points);
SetUpAndInitializeGraph(handler, kOneInput, kOneOutput); ASSERT_OK(SetUpAndInitializeGraph(handler, kOneInput, kOneOutput));
{ {
testing::InSequence s; testing::InSequence s;
@ -459,7 +459,7 @@ TEST_F(CueAlignmentHandlerTest, TextInputWithCues) {
SyncPointQueue sync_points(params); SyncPointQueue sync_points(params);
std::shared_ptr<MediaHandler> handler = std::shared_ptr<MediaHandler> handler =
std::make_shared<CueAlignmentHandler>(&sync_points); std::make_shared<CueAlignmentHandler>(&sync_points);
SetUpAndInitializeGraph(handler, kOneInput, kOneOutput); ASSERT_OK(SetUpAndInitializeGraph(handler, kOneInput, kOneOutput));
{ {
testing::InSequence s; testing::InSequence s;
@ -518,7 +518,7 @@ TEST_F(CueAlignmentHandlerTest, TextInputWithCueAfterLastStart) {
SyncPointQueue sync_points(params); SyncPointQueue sync_points(params);
std::shared_ptr<MediaHandler> handler = std::shared_ptr<MediaHandler> handler =
std::make_shared<CueAlignmentHandler>(&sync_points); std::make_shared<CueAlignmentHandler>(&sync_points);
SetUpAndInitializeGraph(handler, kOneInput, kOneOutput); ASSERT_OK(SetUpAndInitializeGraph(handler, kOneInput, kOneOutput));
{ {
testing::InSequence s; testing::InSequence s;
@ -579,7 +579,7 @@ TEST_F(CueAlignmentHandlerTest, TextAudioVideoInputWithCues) {
SyncPointQueue sync_points(params); SyncPointQueue sync_points(params);
std::shared_ptr<MediaHandler> handler = std::shared_ptr<MediaHandler> handler =
std::make_shared<CueAlignmentHandler>(&sync_points); std::make_shared<CueAlignmentHandler>(&sync_points);
SetUpAndInitializeGraph(handler, kThreeInput, kThreeOutput); ASSERT_OK(SetUpAndInitializeGraph(handler, kThreeInput, kThreeOutput));
{ {
testing::InSequence s; testing::InSequence s;