Mirror-Tools
/
shaka-packager
mirror of https://github.com/shaka-project/shaka-packager.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix ClosureThread unittest crash in release build 

The crash happens if the thread is created but never started. An
improper Join triggered the crash. We should not call Join if the thread
is not started.

Change-Id: Icace740889089d3b2e15cf6c76c2b0887eb84535
This commit is contained in:
Kongqun Yang 2014-04-18 18:48:41 -07:00
parent 7fd94950d4
commit c51c6b2731
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
media/base/closure_thread.cc
View File

@ -14,7 +14,7 @@ ClosureThread::ClosureThread(
: base::SimpleThread(name_prefix), task_(task) {} : base::SimpleThread(name_prefix), task_(task) {}
ClosureThread::~ClosureThread() { ClosureThread::~ClosureThread() {
if (!HasBeenJoined()) if (HasBeenStarted() && !HasBeenJoined())
Join(); Join();
} }