Move common manifest flags out of mpd_flags.cc

Also updated documentations.

Fixes #304

Change-Id: I5e8e87b005ebfa9dc78d47e2501585b083120f6c

docs/source/options/dash_options.rst

@@ -28,18 +28,18 @@ DASH options
     Indicates to the player how often to refresh the media presentation
     description in seconds. This value is used for dynamic MPD only.
 
---time_shift_buffer_depth <seconds>
-
-    Guaranteed duration of the time shifting buffer for dynamic media
-    presentations, in seconds.
-
 --suggested_presentation_delay <seconds>
 
     Specifies a delay, in seconds, to be added to the media presentation time.
     This value is used for dynamic MPD only.
 
+--time_shift_buffer_depth <seconds>
+
+    Guaranteed duration of the time shifting buffer for dynamic media
+    presentations, in seconds.
+
 --default_language <language>
 
-    Any tracks tagged with this language will have <Role ... value=\"main\" />
+    Any audio/text tracks tagged with this language will have
-    in the manifest.  This allows the player to choose the correct default
+    <Role ... value=\"main\" /> in the manifest.  This allows the player to
-    language for the content.
+    choose the correct default language for the content.

docs/source/options/hls_options.rst

@@ -24,5 +24,11 @@ HLS options
 
 --time_shift_buffer_depth <seconds>
 
-    Guaranteed duration of the time shifting buffer for LIVE playlist, in
+    Guaranteed duration of the time shifting buffer for LIVE playlists, in
     seconds.
+
+--default_language <language>
+
+    The first audio/text rendition in a group tagged with this language will
+    have 'DEFAULT' attribute set to 'YES'. This allows the player to choose the
+    correct default language for the content.

packager/app/manifest_flags.cc

@@ -0,0 +1,19 @@
+// Copyright 2018 Google Inc. All rights reserved.
+//
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file or at
+// https://developers.google.com/open-source/licenses/bsd
+
+#include "packager/app/manifest_flags.h"
+
+DEFINE_double(time_shift_buffer_depth,
+              1800.0,
+              "Guaranteed duration of the time shifting buffer for HLS LIVE "
+              "playlists and DASH dynamic media presentations, in seconds.");
+DEFINE_string(default_language,
+              "",
+              "For DASH, any audio/text tracks tagged with this language will "
+              "have <Role ... value=\"main\" /> in the manifest; For HLS, the "
+              "first audio/text rendition in a group tagged with this language "
+              "will have 'DEFAULT' attribute set to 'YES'. This allows the "
+              "player to choose the correct default language for the content.");

packager/app/manifest_flags.h

@@ -0,0 +1,17 @@
+// Copyright 2018 Google Inc. All rights reserved.
+//
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file or at
+// https://developers.google.com/open-source/licenses/bsd
+//
+// Common flags applicable to both DASH and HLS.
+
+#ifndef PACKAGER_APP_MANIFEST_FLAGS_H_
+#define PACKAGER_APP_MANIFEST_FLAGS_H_
+
+#include <gflags/gflags.h>
+
+DECLARE_double(time_shift_buffer_depth);
+DECLARE_string(default_language);
+
+#endif  // PACKAGER_APP_MANIFEST_FLAGS_H_

packager/app/mpd_flags.cc

@@ -39,19 +39,10 @@ DEFINE_double(minimum_update_period,
               "Indicates to the player how often to refresh the media "
               "presentation description in seconds. This value is used for "
               "dynamic MPD only.");
-DEFINE_double(time_shift_buffer_depth,
-              1800.0,
-              "Guaranteed duration of the time shifting buffer for dynamic "
-              "media presentations, in seconds.");
 DEFINE_double(suggested_presentation_delay,
               0.0,
               "Specifies a delay, in seconds, to be added to the media "
               "presentation time. This value is used for dynamic MPD only.");
-DEFINE_string(default_language,
-              "",
-              "Any tracks tagged with this language will have "
-              "<Role ... value=\"main\" /> in the manifest.  This allows the "
-              "player to choose the correct default language for the content.");
 DEFINE_bool(generate_dash_if_iop_compliant_mpd,
             true,
             "Try to generate DASH-IF IOP compliant MPD. This is best effort "

packager/app/mpd_flags.h

@@ -17,9 +17,7 @@ DECLARE_string(mpd_output);
 DECLARE_string(base_urls);
 DECLARE_double(minimum_update_period);
 DECLARE_double(min_buffer_time);
-DECLARE_double(time_shift_buffer_depth);
 DECLARE_double(suggested_presentation_delay);
-DECLARE_string(default_language);
 DECLARE_bool(generate_dash_if_iop_compliant_mpd);
 
 #endif  // APP_MPD_FLAGS_H_

packager/app/packager_main.cc

@@ -10,6 +10,7 @@
 #include "packager/app/ad_cue_generator_flags.h"
 #include "packager/app/crypto_flags.h"
 #include "packager/app/hls_flags.h"
+#include "packager/app/manifest_flags.h"
 #include "packager/app/mpd_flags.h"
 #include "packager/app/muxer_flags.h"
 #include "packager/app/packager_util.h"

packager/packager.gyp

@@ -70,6 +70,8 @@
         'app/gflags_hex_bytes.h',
         'app/hls_flags.cc',
         'app/hls_flags.h',
+        'app/manifest_flags.cc',
+        'app/manifest_flags.h',
         'app/mpd_flags.cc',
         'app/mpd_flags.h',
         'app/muxer_flags.cc',