From dd935f6dc3b42c941305e7b06f930324c48a955a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Cantar=C3=ADn?= Date: Tue, 9 Mar 2021 15:10:32 -0300 Subject: [PATCH] TTML: change "imagetype" attribute to camel case Fixes #908 --- packager/media/formats/ttml/ttml_generator.cc | 2 +- packager/media/formats/ttml/ttml_generator_unittest.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packager/media/formats/ttml/ttml_generator.cc b/packager/media/formats/ttml/ttml_generator.cc index fef7d87828..c0505de646 100644 --- a/packager/media/formats/ttml/ttml_generator.cc +++ b/packager/media/formats/ttml/ttml_generator.cc @@ -216,7 +216,7 @@ bool TtmlGenerator::ConvertFragmentToXml(const TextFragment& body, std::string id = "img_" + std::to_string(++*image_count); xml::XmlNode image_xml("smpte:image"); - RCHECK(image_xml.SetStringAttribute("imagetype", "PNG")); + RCHECK(image_xml.SetStringAttribute("imageType", "PNG")); RCHECK(image_xml.SetStringAttribute("encoding", "Base64")); RCHECK(image_xml.SetStringAttribute("xml:id", id)); image_xml.SetContent(base64_data); diff --git a/packager/media/formats/ttml/ttml_generator_unittest.cc b/packager/media/formats/ttml/ttml_generator_unittest.cc index b17dcb8c09..5997d77719 100644 --- a/packager/media/formats/ttml/ttml_generator_unittest.cc +++ b/packager/media/formats/ttml/ttml_generator_unittest.cc @@ -334,7 +334,7 @@ TEST_F(TtmlMuxerTest, HandlesImage) { "xmlns:smpte=\"http://www.smpte-ra.org/schemas/2052-1/2010/smpte-tt\">\n" " \n" " \n" - " " + " " "AQID\n" " \n" " \n"