From f97413bf6e189e897a059fa6be8424e8f1618699 Mon Sep 17 00:00:00 2001 From: KongQun Yang Date: Tue, 3 Jul 2018 22:12:37 -0700 Subject: [PATCH] Suppress C4819 in Windows There are non-ASCII characters in comment section of some source code, which is causing compilation problems on some systems with a codepage that cannot represent these characters. Fixes #419. Change-Id: I20d68a201263d515290ee440b52c5354b739099a --- packager/common.gypi | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/packager/common.gypi b/packager/common.gypi index 6f61d74ec5..b5c5dbe9c0 100644 --- a/packager/common.gypi +++ b/packager/common.gypi @@ -42,15 +42,13 @@ '-Wno-reserved-user-defined-literal', ], }, - 'conditions': [ - ['OS == "win"', { - 'msvs_settings': { - 'VCCLCompilerTool': { - 'WarnAsError': 'true', - 'DisableSpecificWarnings': ['4125'] - }, - }, - }], + # TODO(kqyang): Fix these msvs warnings. + 'msvs_disabled_warnings': [ + 4125, # Decimal digit terminates octal escape sequence, e.g. "\709". + 4819, # The file contains a character that cannot be represented in + # the current code page. It typically happens when compiling + # the code in CJK environment if there is non-ASCII characters + # in the file. ], }, { # We do not have control over non-shaka code. Disable some warnings to @@ -61,6 +59,12 @@ '-Wno-unguarded-availability', ], }, + 'msvs_disabled_warnings': [ + 4819, # The file contains a character that cannot be represented in + # the current code page. It typically happens when compiling + # the code in CJK environment if there is non-ASCII characters + # in the file. + ], 'conditions': [ ['clang==0', { 'cflags': [