c87c5bcdef
## The issue - With LL-DASH mode enabled, the gap size warning was hit and printed to the console every time a new segment was registered to the manifest. - This occurred because the first chunk's size and duration were being stored for each segment, rather than the full segment size and duration. Note, only the first chunk's metrics are known at first because in low latency mode, the segment is registered to the manifest before it is finished being processed and written. - Because of this, the gap size check was comparing the end time of the first chunk in the previous segment to the beginning time of the current segment, causing the check to fail every time. ## The Fix - Update a low latency segment's duration and size once the segment file has been fully written. - The full segment size and duration will be used to update the bandwidth estimator and the segment info list. - Updating the segment info list to hold the full duration is necessary for satisfying [the gap size check found in Represenation.cc](https://github.com/google/shaka-packager/blob/master/packager/mpd/base/representation.cc#L391). - NOTE: bandwidth estimation is currently only used in HLS |
||
|---|---|---|
| .. | ||
| base | ||
| chunking | ||
| codecs | ||
| crypto | ||
| demuxer | ||
| event | ||
| formats | ||
| origin | ||
| public | ||
| replicator | ||
| test | ||
| trick_play | ||