From cc4900a2ed6366e18081345ce09740645130d056 Mon Sep 17 00:00:00 2001 From: rlaphoenix Date: Tue, 9 Jan 2024 12:54:27 +0000 Subject: [PATCH] Remove uses of the downloader's silent arg in DASH and HLS This was originally done to prevent *all* aria2c logs unless on the last attempt, at which if it failed all attempts it would let aria2c log the error. However, that's bad practice as aria2c may produce errors or warnings on say the 3rd attempt, and the 3rd attempt may have otherwise succeeded, with warnings or errors. It also generally shouldn't be necessary. --- devine/core/manifests/dash.py | 1 - devine/core/manifests/hls.py | 1 - 2 files changed, 2 deletions(-) diff --git a/devine/core/manifests/dash.py b/devine/core/manifests/dash.py index 4fc812c..07417e5 100644 --- a/devine/core/manifests/dash.py +++ b/devine/core/manifests/dash.py @@ -535,7 +535,6 @@ class DASH: headers=headers_, cookies=cookies, proxy=proxy, - silent=attempts != 5, segmented=True ) break diff --git a/devine/core/manifests/hls.py b/devine/core/manifests/hls.py index 1e3a775..70960d2 100644 --- a/devine/core/manifests/hls.py +++ b/devine/core/manifests/hls.py @@ -441,7 +441,6 @@ class HLS: headers=headers_, cookies=session.cookies, proxy=proxy, - silent=attempts != 5, segmented=True ) break