Mirror-Tools
/
shaka-packager
mirror of https://github.com/shaka-project/shaka-packager.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Skip clang updates on Windows 

We do not use clang to build on Windows, so we should skip trying to
update clang.  This is critical to MSVS 2019 support, since the older
clang tools we depend on do not recognize that newer environment.
Since we don't need clang anyway, skipping the update avoids useless
errors about finding a matching clang version for the environment.

Issue #867 (MSVS 2019)
Issue #336 (progress toward replacing Travis & Appveyor with GitHub
  Actions, which uses MSVS 2019)
b/190743862 (internal; tracking replacement of Travis)

Change-Id: I5600ed809b11e68444034a06cc891403e6bfb5cc
This commit is contained in:
Joey Parrish 2021-06-14 12:14:02 -07:00
parent ae89145015
commit 98782c051e
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
DEPS
View File

@ -111,6 +111,8 @@ hooks = [
{ {
# Pull clang if needed or requested via GYP_DEFINES (GYP_DEFINES="clang=1"). # Pull clang if needed or requested via GYP_DEFINES (GYP_DEFINES="clang=1").
"name": "clang", "name": "clang",
# Skip clang updates on Windows, where we don't use clang.
"condition": "not checkout_win",
"pattern": ".", "pattern": ".",
"action": ["python", "src/packager/tools/clang/scripts/update.py", "--if-needed"], "action": ["python", "src/packager/tools/clang/scripts/update.py", "--if-needed"],
}, },