Mirror-Tools
/
shaka-packager
mirror of https://github.com/shaka-project/shaka-packager.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

TTML: change "imagetype" attribute to camel case 

Fixes #908
This commit is contained in:
Daniel Cantarín 2021-03-09 15:10:32 -03:00 committed by GitHub
parent f9908362f8
commit dd935f6dc3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packager/media/formats/ttml/ttml_generator.cc
View File

@ -216,7 +216,7 @@ bool TtmlGenerator::ConvertFragmentToXml(const TextFragment& body,
std::string id = "img_" + std::to_string(++*image_count); std::string id = "img_" + std::to_string(++*image_count);
xml::XmlNode image_xml("smpte:image"); xml::XmlNode image_xml("smpte:image");
RCHECK(image_xml.SetStringAttribute("imagetype", "PNG")); RCHECK(image_xml.SetStringAttribute("imageType", "PNG"));
RCHECK(image_xml.SetStringAttribute("encoding", "Base64")); RCHECK(image_xml.SetStringAttribute("encoding", "Base64"));
RCHECK(image_xml.SetStringAttribute("xml:id", id)); RCHECK(image_xml.SetStringAttribute("xml:id", id));
image_xml.SetContent(base64_data); image_xml.SetContent(base64_data);

2
packager/media/formats/ttml/ttml_generator_unittest.cc
View File

@ -334,7 +334,7 @@ TEST_F(TtmlMuxerTest, HandlesImage) {
"xmlns:smpte=\"http://www.smpte-ra.org/schemas/2052-1/2010/smpte-tt\">\n" "xmlns:smpte=\"http://www.smpte-ra.org/schemas/2052-1/2010/smpte-tt\">\n"
" <head/>\n" " <head/>\n"
" <metadata>\n" " <metadata>\n"
" <smpte:image imagetype=\"PNG\" encoding=\"Base64\" xml:id=\"img_1\">" " <smpte:image imageType=\"PNG\" encoding=\"Base64\" xml:id=\"img_1\">"
"AQID</smpte:image>\n" "AQID</smpte:image>\n"
" </metadata>\n" " </metadata>\n"
" <body>\n" " <body>\n"