Suppress C4819 in Windows

There are non-ASCII characters in comment section of some source
code, which is causing compilation problems on some systems with
a codepage that cannot represent these characters.

Fixes #419.

Change-Id: I20d68a201263d515290ee440b52c5354b739099a
This commit is contained in:
KongQun Yang 2018-07-03 22:12:37 -07:00
parent a510d3aa38
commit f97413bf6e
1 changed files with 13 additions and 9 deletions

View File

@ -42,15 +42,13 @@
'-Wno-reserved-user-defined-literal', '-Wno-reserved-user-defined-literal',
], ],
}, },
'conditions': [ # TODO(kqyang): Fix these msvs warnings.
['OS == "win"', { 'msvs_disabled_warnings': [
'msvs_settings': { 4125, # Decimal digit terminates octal escape sequence, e.g. "\709".
'VCCLCompilerTool': { 4819, # The file contains a character that cannot be represented in
'WarnAsError': 'true', # the current code page. It typically happens when compiling
'DisableSpecificWarnings': ['4125'] # the code in CJK environment if there is non-ASCII characters
}, # in the file.
},
}],
], ],
}, { }, {
# We do not have control over non-shaka code. Disable some warnings to # We do not have control over non-shaka code. Disable some warnings to
@ -61,6 +59,12 @@
'-Wno-unguarded-availability', '-Wno-unguarded-availability',
], ],
}, },
'msvs_disabled_warnings': [
4819, # The file contains a character that cannot be represented in
# the current code page. It typically happens when compiling
# the code in CJK environment if there is non-ASCII characters
# in the file.
],
'conditions': [ 'conditions': [
['clang==0', { ['clang==0', {
'cflags': [ 'cflags': [