ninjajiraiya
/
devine
forked from DRMTalks/devine
1
0
Fork 0
Code Pull Requests Activity

master #1

Merged
ninjajiraiya merged 2 commits from DRMTalks/devine:master into master 2024-03-12 02:57:19 +00:00
Conversation 0 Commits 2 Files Changed 2 +7 -3
ninjajiraiya commented 2024-03-12 02:57:09 +00:00
Owner
Copy Link
No description provided.
ninjajiraiya added 2 commits 2024-03-12 02:57:10 +00:00
5376e4c042 refactor(Service): Go back to the default pool_maxsize in Session 
The pool_maxsize value here isn't actually doing much. It should have also been applied to pool_connections. What we realistically needed was just pool_block to prevent opening too much connections (causing a warning). The default pool_connections=10 and pool_maxsize=10 is fine. The downloader doesn't currently use this value.
1bff87bd70 fix(requests): Set HTTP pool connections/maxsize to max workers 
This allows requests to open and save/cache up to *max_workers* amount of TCP connections. In most situations it will still only save and re-use one TCP Connection since it always tries to re-use the connection if one is available.

However, in situations where downloads are from more than 10 Host/Port combinations (the default pool connections/maxsize) then this will improve download speeds.
ninjajiraiya merged commit 905f5706eb into master 2024-03-12 02:57:19 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: ninjajiraiya/devine#1
No description provided.
Delete Branch "DRMTalks/devine:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?