master #1

Merged

ninjajiraiya merged 2 commits from DRMTalks/devine:master into master

2024-03-12 02:57:19 +00:00

Author	SHA1	Message	Date
rlaphoenix	1bff87bd70	fix(requests): Set HTTP pool connections/maxsize to max workers This allows requests to open and save/cache up to max_workers amount of TCP connections. In most situations it will still only save and re-use one TCP Connection since it always tries to re-use the connection if one is available. However, in situations where downloads are from more than 10 Host/Port combinations (the default pool connections/maxsize) then this will improve download speeds.	2024-03-12 01:06:42 +00:00
rlaphoenix	5376e4c042	refactor(Service): Go back to the default pool_maxsize in Session The pool_maxsize value here isn't actually doing much. It should have also been applied to pool_connections. What we realistically needed was just pool_block to prevent opening too much connections (causing a warning). The default pool_connections=10 and pool_maxsize=10 is fine. The downloader doesn't currently use this value.	2024-03-12 00:59:30 +00:00

Author

SHA1

Message

Date

rlaphoenix

1bff87bd70

fix(requests): Set HTTP pool connections/maxsize to max workers

This allows requests to open and save/cache up to *max_workers* amount of TCP connections. In most situations it will still only save and re-use one TCP Connection since it always tries to re-use the connection if one is available.

However, in situations where downloads are from more than 10 Host/Port combinations (the default pool connections/maxsize) then this will improve download speeds.

2024-03-12 01:06:42 +00:00

rlaphoenix

5376e4c042

refactor(Service): Go back to the default pool_maxsize in Session

The pool_maxsize value here isn't actually doing much. It should have also been applied to pool_connections. What we realistically needed was just pool_block to prevent opening too much connections (causing a warning). The default pool_connections=10 and pool_maxsize=10 is fine. The downloader doesn't currently use this value.

2024-03-12 00:59:30 +00:00

master #1

2 Commits